Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.amqp_consumer): Add support to rabbitmq stream queue #13496

Merged
merged 6 commits into from
Jun 27, 2023
Merged

feat(inputs.amqp_consumer): Add support to rabbitmq stream queue #13496

merged 6 commits into from
Jun 27, 2023

Conversation

massimogallina
Copy link
Contributor

@massimogallina massimogallina commented Jun 26, 2023

resolves #13479

Add QueueConsumeArguments to manage the x-stream-offset for RabbitMQ stream queue.

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@massimogallina massimogallina changed the title Rabbitmq stream feat: (input.amqp_consumer): add support to rabbitmq stream queue Jun 26, 2023
@massimogallina
Copy link
Contributor Author

!signed-cla

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @massimogallina! Can you please run make fmt to make the CI tests pass!?

Furthermore, I would love to see a unit-test with arguments to make sure we do not break this functionality in later PRs...

@srebhan srebhan self-assigned this Jun 27, 2023
@srebhan srebhan changed the title feat: (input.amqp_consumer): add support to rabbitmq stream queue feat(inputs.amqp_consumer): Add support to rabbitmq stream queue Jun 27, 2023
@srebhan srebhan added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/rabbitmq plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 27, 2023
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution @massimogallina!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 27, 2023
@srebhan srebhan assigned powersj and unassigned srebhan Jun 27, 2023
@powersj powersj merged commit ef86635 into influxdata:master Jun 27, 2023
@srebhan srebhan added this to the v1.28.0 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rabbitmq feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the support of rabbitmq stream queue on amqp_consumer input plugin
3 participants