Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kafka): Set and send SASL extensions #13411

Merged
merged 1 commit into from
Jul 14, 2023
Merged

feat(kafka): Set and send SASL extensions #13411

merged 1 commit into from
Jul 14, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jun 8, 2023

No description provided.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 8, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 8, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj self-assigned this Jun 9, 2023
@powersj powersj closed this Jul 7, 2023
@srebhan srebhan reopened this Jul 13, 2023
srebhan
srebhan approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @powersj!

@powersj powersj marked this pull request as ready for review July 13, 2023 16:51
@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Jul 14, 2023
@srebhan
Copy link
Member

srebhan commented Jul 14, 2023

@powersj assigning it back to you in case you want to check again. Feel free to merge as-soon-as you think it's ready.

@powersj powersj merged commit d4235ab into influxdata:master Jul 14, 2023
@powersj powersj deleted the feat/kafka-extensions branch July 14, 2023 15:24
@github-actions github-actions bot added this to the v1.28.0 milestone Jul 14, 2023
@powersj powersj restored the feat/kafka-extensions branch March 29, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

Labels
area/kafka feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@powersj @srebhan