Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(outputs.sql): Use config.duration to correctly parse toml config #13408

Merged
merged 1 commit into from
Jun 9, 2023
Merged

fix(outputs.sql): Use config.duration to correctly parse toml config #13408

merged 1 commit into from
Jun 9, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jun 8, 2023

fixes: #13406

@telegraf-tiger telegraf-tiger bot added area/sql fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 8, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 8, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 8, 2023
srebhan
srebhan approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @powersj!

@srebhan srebhan changed the title fix(inputs.sql): use config.duration to correctly parse toml config fix(outputs.sql): Use config.duration to correctly parse toml config Jun 9, 2023
@srebhan srebhan added plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins and removed plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 9, 2023
@srebhan
Copy link
Member

srebhan commented Jun 9, 2023

@powersj changed the title and tags to outputs as you modify the output. If this is wrong please let me know!

@srebhan srebhan merged commit 8b815cb into influxdata:master Jun 9, 2023
@powersj
Copy link
Contributor Author

powersj commented Jun 9, 2023

No, it was the output, thank you for the catch

@chenrui333 chenrui333 mentioned this pull request Jun 13, 2023
Merged
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/sql fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.27.0
Development

Successfully merging this pull request may close these issues.

[outputs.sql] Error loading config if connection_max_lifetime is set
2 participants
@powersj @srebhan