Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Intel Baseband Accelerator Input Plugin #13397

Merged
merged 5 commits into from
Jun 9, 2023

Conversation

bkotlowski
Copy link
Contributor

Required for all PRs

resolves #13395

Intel Baseband Accelerator Input Plugin collects metrics from both dedicated and integrated Intel devices that provide Wireless Baseband hardware acceleration. These devices play a key role in accelerating 5G and 4G Virtualized Radio AccessNetworks (vRAN) workloads, increasing the overall compute capacity of a commercial, off-the-shelf platforms.

Intel Baseband devices integrate various features critical for 5G and LTE (Long Term Evolution) networks, including e.g.:

  • Forward Error Correction (FEC) processing,
  • 4G Turbo FEC processing,
  • 5G Low Density Parity Check (LDPC)
  • a Fast Fourier Transform (FFT) block providing DFT/iDFT processing offload for the 5G Sounding Reference Signal (SRS)

The source of metrics is pf-bb-config

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 6, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bkotlowski for the nice contribution! I do have some minor comments, but my biggest concern is the wait_for_telemetry_delay option. It cannot be easily chosen by the user and it strongly depends on the system and system state. As such there is no good default and people will likely complain that the plugin doesn't work if it is chosen wrong... I recommend trying to watch the log-file for completeness instead of waiting a fixed time...

@srebhan srebhan self-assigned this Jun 6, 2023
@srebhan srebhan added new plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jun 6, 2023
bkotlowski and others added 5 commits June 6, 2023 18:42
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 8, 2023

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bkotlowski and @p-zak for the quick action cycles!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 9, 2023
@srebhan srebhan assigned powersj and unassigned srebhan Jun 9, 2023
@powersj powersj merged commit 09adec7 into influxdata:master Jun 9, 2023
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin new plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Intel Baseband Accelerator Input Plugin
4 participants