-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Intel Baseband Accelerator Input Plugin #13397
Conversation
14fb16e
to
3053050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bkotlowski for the nice contribution! I do have some minor comments, but my biggest concern is the wait_for_telemetry_delay
option. It cannot be easily chosen by the user and it strongly depends on the system and system state. As such there is no good default and people will likely complain that the plugin doesn't work if it is chosen wrong... I recommend trying to watch the log-file for completeness instead of waiting a fixed time...
Co-authored-by: PanKaker <92713340+PanKaker@users.noreply.github.com> Co-authored-by: bkotlowski <bartlomiej.kotlowski@gmial.com>
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @bkotlowski and @p-zak for the quick action cycles!
Required for all PRs
resolves #13395
Intel Baseband Accelerator Input Plugin collects metrics from both dedicated and integrated Intel devices that provide Wireless Baseband hardware acceleration. These devices play a key role in accelerating 5G and 4G Virtualized Radio AccessNetworks (vRAN) workloads, increasing the overall compute capacity of a commercial, off-the-shelf platforms.
Intel Baseband devices integrate various features critical for 5G and LTE (Long Term Evolution) networks, including e.g.:
The source of metrics is pf-bb-config