Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.mqtt): ack messages when persistence enabled #13350

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented May 26, 2023

Currently, the paho.mqtt.golang client will ack messages as they come in. When the persistent session option a user would expect telegraf to ack the messages only once they have been sent or parsed sucessfully.

This disables the client's auto ack if persistent session is enabled. It also sets up telegraf to ack messages once they were sent. Additionally, if we fail to parse the message we will ack the message.

Currently, the paho.mqtt.golang client will ack messages as they come
in. When the persistent session option a user would expect telegraf to
ack the messages only once they have been sent or parsed sucessfully.

This disables the client's auto ack if persistent session is enabled. It
also sets up telegraf to ack messages once they were sent. Additionally,
if we fail to parse the message we will ack the message.
@telegraf-tiger telegraf-tiger bot added area/mqtt fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 26, 2023
@powersj powersj marked this pull request as ready for review May 31, 2023 19:10
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 31, 2023
@srebhan srebhan merged commit ebe3461 into influxdata:master Jun 7, 2023
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mqtt fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants