Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.netflow): Handle PEN messages correctly #13320

Merged
merged 8 commits into from
May 24, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented May 23, 2023

resolves #13305

Messages containing Private Enterprise Numbers (PEN) can define arbitrary elements with IDs colliding with the generally defined element IDs. Therefore, we need to respect the PEN information when doing the lookup in order to not misinterpret elements (e.g. redefined with a different type).

This PR separates the PEN message from the general message lookup by respecting the PEN flag. As we currently have no means in specifying PEN information, those fields will be reported as fields with a type_<pen-number>_<element_id> key and hex-encoded values.
Furthermore, the PR converts a "missing template" error to a warning.

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 23, 2023
@vknyazhev
Copy link

@srebhan I don't understand a bit, do I need to run some file (what?) on the host on which telegraf is running?

@srebhan srebhan added area/network New plugins or feature relating to Network Monitoring ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels May 24, 2023
@srebhan srebhan removed the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 24, 2023
@powersj
Copy link
Contributor

powersj commented May 24, 2023

@srebhan I'm assigned, but you removed ready for final review? ;)

@srebhan srebhan force-pushed the netflow_issue_13305 branch from 4b55988 to fe897ec Compare May 24, 2023 13:14
@srebhan
Copy link
Member Author

srebhan commented May 24, 2023

@powersj yeah I split out one of the commits into #13325 so I wanted to wait until this is in... Rebase is done now, will re-tag as soon as the tests are through...

@telegraf-tiger
Copy link
Contributor

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 24, 2023
@srebhan
Copy link
Member Author

srebhan commented May 24, 2023

@powersj tests passed...

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj merged commit 60ee14d into influxdata:master May 24, 2023
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/network New plugins or feature relating to Network Monitoring fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error processing IPFIX messages using telegraf [[inputs.netflow]]
3 participants