-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.netflow): Handle PEN messages correctly #13320
Conversation
@srebhan I don't understand a bit, do I need to run some file (what?) on the host on which telegraf is running? |
@srebhan I'm assigned, but you removed ready for final review? ;) |
4b55988
to
fe897ec
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
@powersj tests passed... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
resolves #13305
Messages containing Private Enterprise Numbers (PEN) can define arbitrary elements with IDs colliding with the generally defined element IDs. Therefore, we need to respect the PEN information when doing the lookup in order to not misinterpret elements (e.g. redefined with a different type).
This PR separates the PEN message from the general message lookup by respecting the PEN flag. As we currently have no means in specifying PEN information, those fields will be reported as fields with a
type_<pen-number>_<element_id>
key and hex-encoded values.Furthermore, the PR converts a "missing template" error to a warning.