feat(inputs.sqlserver): Check SQL Server "encryptionEnforce" with xp_instance_regread

plugins/inputs/sqlserver/README.md

@@ -441,7 +441,6 @@ ensure to check additional setup section in this documentation.
   - *TempDB*: Free space, Version store usage, Active temp tables, temp table creation rate, + more
   - *Resource Governor*: CPU Usage, Requests/sec, Queued Requests, and Blocked tasks per workload group + more
 - *SQLServerProperties*: Number of databases in all possible states (online, offline, suspect, etc.), cpu count, total physical memory, available physical memory, SQL Server service uptime, SQL Server SPID and SQL Server version. In the case of Azure SQL relevant properties such as Tier, #Vcores, Memory etc.
-- *SQLServerForceEncryption*: Retrieves info from registry if SQL Server is having forced encryption
 - *SQLServerWaitStatsCategorized*: Wait time in ms, number of waiting tasks, resource wait time, signal wait time, max wait time in ms, wait type, and wait category. The waits are categorized using the same categories used in Query Store.
 - *SQLServerSchedulers*: This captures `sys.dm_os_schedulers`.
 - *SQLServerRequests*: This captures a snapshot of `sys.dm_exec_requests` and `sys.dm_exec_sessions` that gives you running requests as well as wait types and

plugins/inputs/sqlserver/sqlserver.go

@@ -130,7 +130,6 @@ func (s *SQLServer) initQueries() error {
 	} else if s.DatabaseType == typeAzureArcSQLManagedInstance {
 		queries["AzureArcSQLMIDatabaseIO"] = Query{ScriptName: "AzureArcSQLMIDatabaseIO", Script: sqlAzureArcMIDatabaseIO, ResultByRow: false}
 		queries["AzureArcSQLMIServerProperties"] = Query{ScriptName: "AzureArcSQLMIServerProperties", Script: sqlAzureArcMIProperties, ResultByRow: false}
-		queries["SQLServerForceEncryption"] = Query{ScriptName: "SQLServerForceEncryption", Script: SQLServerForceEncryption, ResultByRow: false}
 		queries["AzureArcSQLMIOsWaitstats"] = Query{ScriptName: "AzureArcSQLMIOsWaitstats", Script: sqlAzureArcMIOsWaitStats, ResultByRow: false}
 		queries["AzureArcSQLMIMemoryClerks"] = Query{ScriptName: "AzureArcSQLMIMemoryClerks", Script: sqlAzureArcMIMemoryClerks, ResultByRow: false}
 		queries["AzureArcSQLMIPerformanceCounters"] =

plugins/inputs/sqlserver/sqlserverqueries.go

@@ -211,6 +211,29 @@ IF CAST(SERVERPROPERTY('ProductVersion') AS varchar(50)) >= '10.50.2500.0'
 	END AS [hardware_type]'
 
 SET @SqlStatement = '
+
+DECLARE @ForceEncryption INT
+DECLARE @DynamicportNo NVARCHAR(50);
+DECLARE @StaticportNo NVARCHAR(50);
+
+EXEC [master].[dbo].[xp_instance_regread]
+       @rootkey = ''HKEY_LOCAL_MACHINE'',
+       @key = ''SOFTWARE\Microsoft\Microsoft SQL Server\MSSQLServer\SuperSocketNetLib'',
+       @value_name = ''ForceEncryption'',
+       @value = @ForceEncryption OUTPUT;
+
+EXEC xp_instance_regread @rootkey = ''HKEY_LOCAL_MACHINE''
+                        ,@key =
+                         ''Software\Microsoft\Microsoft SQL Server\MSSQLServer\SuperSocketNetLib\Tcp\IpAll''
+                        ,@value_name = ''TcpDynamicPorts''
+                        ,@value = @DynamicportNo OUTPUT
+
+EXEC xp_instance_regread @rootkey = ''HKEY_LOCAL_MACHINE''
+                        ,@key =
+                         ''Software\Microsoft\Microsoft SQL Server\MSSQLServer\SuperSocketNetLib\Tcp\IpAll''
+                        ,@value_name = ''TcpPort''
+                        ,@value = @StaticportNo OUTPUT
+
 SELECT
 	 ''sqlserver_server_properties'' AS [measurement]
 	,REPLACE(@@SERVERNAME,''\'','':'') AS [sql_instance]
@@ -224,6 +247,9 @@ SELECT
 	,SERVERPROPERTY(''ProductVersion'') AS [sql_version]
 	,SERVERPROPERTY(''IsClustered'') AS [instance_type]
 	,LEFT(@@VERSION,CHARINDEX('' - '',@@VERSION)) AS [sql_version_desc]
+	,@ForceEncryption AS ForceEncryption
+	,COALESCE(@DynamicportNo,@StaticportNo) AS Port
+	,IIF(@DynamicportNo IS NULL, ''Static'', ''Dynamic'') AS PortType
 	,dbs.[db_online]
 	,dbs.[db_restoring]
 	,dbs.[db_recovering]
@@ -247,24 +273,6 @@ SELECT
 EXEC sp_executesql @SqlStatement
 `
 
-const SQLServerForceEncryption = `
-SET DEADLOCK_PRIORITY -10;
-
-DECLARE 
-@ForceEncryption INT
-,@SqlStatement AS nvarchar(max)
-
-SET @SqlStatement = N'
-EXEC xp_instance_regread 
-	@rootkey = 'HKEY_LOCAL_MACHINE', 
-	@key = 'SOFTWARE\Microsoft\Microsoft SQL Server\MSSQLServer\SuperSocketNetLib', 
-	@value_name = 'ForceEncryption',
-	@value = @ForceEncryption OUTPUT
-SELECT @ForceEncryption AS ForceEncryption'
-
-EXEC sp_executesql @SqlStatement
-`
-
 const sqlServerSchedulers string = `
 SET DEADLOCK_PRIORITY -10;
 IF SERVERPROPERTY('EngineEdition') NOT IN (2,3,4) BEGIN /*NOT IN Standard,Enterpris,Express*/