feat(inputs.sqlserver): add Azure Arc-enabled SQL MI support

[nikosheng]

Required for all PRs

• Updated associated README.md.
• Wrote appropriate unit tests.
• Pull request title or commits are in conventional commit format

resolves #13145

Add an sqlserver input plugin to support Azure Arc-enabled SQL Managed Instance. Currently, the plugin is not able to support the Azure Arc-enabled SQL MI due to engine edition checking.

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

[nikosheng]

@powersj Hi Joshua, happy to know if any follow up for this PR.

[srebhan]

Looks good code-wise. Cannot judge the SQL query part. @Trovalo any comments?

[Trovalo]

I've no knowledge of Arc-Enabled SQL Server, and I've no way of testing the queries but I trust the work of @nikosheng.
Just one question tho (for my own curiosity), if the only limit was the engine check wouldn't it suffice to just expand that rule instead of creating a whole new branch of queries? Or is there something more, like different or additional queries?

[nikosheng]

I've no knowledge of Arc-Enabled SQL Server, and I've no way of testing the queries but I trust the work of @nikosheng. Just one question tho (for my own curiosity), if the only limit was the engine check wouldn't it suffice to just expand that rule instead of creating a whole new branch of queries? Or is there something more, like different or additional queries?

Hi @Trovalo , your assumption is correct as some system internal DMVs are not available in Azure Arc-enabled SQL MI. For instance, sys.server_resource_stats is not available to catch any data in Azure Arc-enabled SQL MI, therefore we need to get the metadata from other source DMV or table. Same as the Resource Governance which is not available in Azure Arc-enabled SQL MI.

Therefore, to add more flexibility, I suggest separating Azure Arc-enabled SQL MI and SQL MI to be better to create a new rule to specifically adapt to Azure Arc-enabled SQL MI for feature enablement in the future. Hope it makes sense.

CC: @srebhan

[powersj]

Thank you for taking the time to put this up!

[powersj]

Thank you for taking the time to put this up!