Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump github.com/signalfx/golib from 3.3.46 to 3.3.50 #13230

Merged
merged 1 commit into from
May 4, 2023
Merged

chore(deps): Bump github.com/signalfx/golib from 3.3.46 to 3.3.50 #13230

merged 1 commit into from
May 4, 2023

Conversation

LukeWinikates
Copy link
Contributor

@LukeWinikates LukeWinikates commented May 3, 2023 •
edited
Loading

this PR bumps signalfx/golib to v3.3.49 v3.3.50

@telegraf-tiger telegraf-tiger bot added the chore label May 3, 2023
@powersj powersj changed the title chore(deps): bump signalfx/golib to v3.3.49 chore(deps): bump signalfx/golib from 3.3.46 to 3.3.49 May 3, 2023
powersj
powersj approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - any reason not to go all the way to 3.3.50? Looking at the diff it is largely changes due to the jump up to go1.19

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 3, 2023
@LukeWinikates LukeWinikates force-pushed the bump-signalfx-golib branch 2 times, most recently from 67eac80 to 147ae60 Compare May 3, 2023 16:40
@LukeWinikates LukeWinikates changed the title chore(deps): bump signalfx/golib from 3.3.46 to 3.3.49 chore(deps): bump signalfx/golib from 3.3.46 to 3.3.50 May 3, 2023
@LukeWinikates
Copy link
Contributor Author

@powersj thanks for spotting the even newer version. Looks like the released 3.3.50 just a couple of hours after I started looking at this.

Apologies for the force push after you added the ready for final review label!

powersj
powersj approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with v3.3.50 as well and no worries :)

@srebhan srebhan added the dependencies Pull requests that update a dependency file label May 4, 2023
@srebhan srebhan changed the title chore(deps): bump signalfx/golib from 3.3.46 to 3.3.50 chore(deps): Bump github.com/signalfx/golib from 3.3.46 to 3.3.50 May 4, 2023
srebhan
srebhan approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LukeWinikates!

@srebhan
Copy link
Member

srebhan commented May 4, 2023

@LukeWinikates can you please resolve the conflict so we can merge this PR!?

@LukeWinikates LukeWinikates force-pushed the bump-signalfx-golib branch from 147ae60 to c5889a3 Compare May 4, 2023 19:22
@LukeWinikates
Copy link
Contributor Author

@srebhan sure thing! rebased onto the master branch and re-ran go mod tidy.

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented May 4, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 3.53 % for linux amd64 (new size: 181.3 MB, nightly size 175.1 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj merged commit a579168 into influxdata:master May 4, 2023
powersj pushed a commit that referenced this pull request May 22, 2023
@LukeWinikates @powersj
chore(deps): bump signalfx/golib from 3.3.46 to 3.3.50 (#13230)
e62689f 
(cherry picked from commit a579168)
@p-linnane p-linnane mentioned this pull request May 22, 2023
Merged
@srebhan srebhan added this to the v1.26.3 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.26.3
Development

Successfully merging this pull request may close these issues.
3 participants
@LukeWinikates @srebhan @powersj