-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OpenTSDB data format parser (mark two) #13167
feat: add OpenTSDB data format parser (mark two) #13167
Conversation
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Thanks so much for the pull request! |
I'll need to get advice on the CLA; I'll leave this as draft until then. |
!signed-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice addition @nick-kentik and sorry for the long response time! I have some minor comments...
Thanks for the review @srebhan ! I've addressed your comments, with a few tweaks in places; I've resolved the comments where I've applied your suggestion unchanged. There's just the discussion about what to do when some lines in the input are invalid; I've not made any changes there yet. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -3.60 % for linux amd64 (new size: 168.8 MB, nightly size 175.1 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your nice contribution @nick-kentik!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Great, thanks for the merge! |
Required for all PRs
resolves #8559
Added a parser for OpenTSDB's Telnet style put API format.
For more detail of the format, see
http://opentsdb.net/docs/build/html/api_telnet/put.html
http://opentsdb.net/docs/build/html/user_guide/writing/index.html#data-specification
This is heavily based on the effort by @envzhu in #9690 - I merged that branch against latest master, then made the (minimal) changes necessary to get it working, and the existing tests passing.
A quick end-to-end test also looked good. Here's the
telegraf.conf
I used:A telnet session as input:
And the
telegraf
process output: