Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.gnmi): create selfstat to track connection state #13149

Merged
merged 2 commits into from
May 2, 2023
Merged

fix(inputs.gnmi): create selfstat to track connection state #13149

merged 2 commits into from
May 2, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Apr 26, 2023

Creates metric for each connection source, with 1 as connected and 0 as disconnected.

fixes: #13088

@telegraf-tiger telegraf-tiger bot added area/gnmi fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 26, 2023
@powersj powersj mentioned this pull request Apr 26, 2023
Closed
@powersj powersj marked this pull request as ready for review April 27, 2023 14:54
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 27, 2023
srebhan
srebhan reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj! Some comments from my side...

@powersj
fix(inputs.gnmi): create selfstat to track connection state
65f27bc 
Creates metric for each connection source, with 1 as connected and 0 as
disconnected.

fixes: influxdata#13088
@powersj @srebhan
Update plugins/inputs/gnmi/handler.go
412c72b 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj
Copy link
Contributor Author

powersj commented Apr 28, 2023

@srebhan accepted your change

srebhan
srebhan approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @powersj!

@srebhan srebhan merged commit f55d214 into influxdata:master May 2, 2023
powersj added a commit that referenced this pull request May 22, 2023
@powersj
fix(inputs.gnmi): Create selfstat to track connection state (#13149)
0f6cb8c 
(cherry picked from commit f55d214)
@p-linnane p-linnane mentioned this pull request May 22, 2023
Merged
@srebhan srebhan added this to the v1.26.3 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/gnmi fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.26.3
Development

Successfully merging this pull request may close these issues.

Add binary metric to monitor gnmi connection state
2 participants
@powersj @srebhan