-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(processors.parser): add merge with timestamp option #13147
Conversation
By default, the merge processor will use the existing timestamp of the metric. This makes somesense when the user wants to keep the timestamp of when the metric was originally created. However, there are cases where if the user is also parsing data at this stage that they may want to set the timestamp as well. Fixes: influxdata#13102
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@powersj LGTM, just one question about the no-valid-time corner case...
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -2.35 % for linux amd64 (new size: 168.7 MB, nightly size 172.8 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @powersj!
By default, the merge processor will use the existing timestamp of the metric. This makes somesense when the user wants to keep the timestamp of when the metric was originally created. However, there are cases where if the user is also parsing data at this stage that they may want to set the timestamp as well.
Fixes: #13102