Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processors.parser): add merge with timestamp option #13147

Merged
merged 3 commits into from
May 3, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Apr 26, 2023

By default, the merge processor will use the existing timestamp of the metric. This makes somesense when the user wants to keep the timestamp of when the metric was originally created. However, there are cases where if the user is also parsing data at this stage that they may want to set the timestamp as well.

Fixes: #13102

By default, the merge processor will use the existing timestamp of the
metric. This makes somesense when the user wants to keep the timestamp
of when the metric was originally created. However, there are cases
where if the user is also parsing data at this stage that they may want
to set the timestamp as well.

Fixes: influxdata#13102
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor labels Apr 26, 2023
@powersj powersj marked this pull request as ready for review May 1, 2023 14:00
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 1, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@powersj LGTM, just one question about the no-valid-time corner case...

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented May 2, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -2.35 % for linux amd64 (new size: 168.7 MB, nightly size 172.8 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @powersj!

@srebhan srebhan merged commit 6dd3bcb into influxdata:master May 3, 2023
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timestamp is dropped by processors.parser if merge = "override" is set
3 participants