Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.intel_pmu): fix handling of the json perfmon format #13139

Merged
merged 2 commits into from
Apr 26, 2023
Merged

fix(inputs.intel_pmu): fix handling of the json perfmon format #13139

merged 2 commits into from
Apr 26, 2023

Conversation

PanKaker
Copy link
Contributor

@PanKaker PanKaker commented Apr 25, 2023 •
edited
Loading

Intel PMU plugin stopped working after introducing new version of json perfmon format.

This PR fixes this bug. More info can be found inside on issue.
Old event format is still accepted.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 25, 2023
@PanKaker PanKaker changed the title feat(inputs.intel_pmu): add additional support for the new json perfmon format fix(inputs.intel_pmu): fix handling of the json perfmon format Apr 25, 2023
@p-zak p-zak added bug unexpected problem or unintended behavior and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Apr 25, 2023
@PanKaker
Copy link
Contributor Author

PanKaker commented Apr 25, 2023 •
edited
Loading

There is failure in CI/CD, but it's not connected with the plugin:
image

https://app.circleci.com/pipelines/github/influxdata/telegraf/16016/workflows/5d61b243-125a-4f02-a173-a786951812b4/jobs/250859?invite=true#step-105-724

@powersj
Copy link
Contributor

powersj commented Apr 25, 2023

I've kicked off the integration test again, as that failure is unrelated to the plugin you changed.

@powersj powersj mentioned this pull request Apr 25, 2023
Closed
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 25, 2023
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the update @PanKaker!

@srebhan srebhan merged commit f297d3e into influxdata:master Apr 26, 2023
@srebhan srebhan added fix pr to fix corresponding bug and removed bug unexpected problem or unintended behavior labels Apr 26, 2023
powersj pushed a commit that referenced this pull request May 22, 2023
@PanKaker @powersj
fix(inputs.intel_pmu): Fix handling of the json perfmon format (#13139)
c6c3e9d 
(cherry picked from commit f297d3e)
@p-linnane p-linnane mentioned this pull request May 22, 2023
Merged
@srebhan srebhan added this to the v1.26.3 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.26.3
Development

Successfully merging this pull request may close these issues.
4 participants
@PanKaker @powersj @srebhan @p-zak