Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.nvidia_smi): add additional memory related fields #13133

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

azherebtsov
Copy link
Contributor

@azherebtsov azherebtsov commented Apr 24, 2023

Adding memory utilisation and page retirement metrics

Required for all PRs

resolves #

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@azherebtsov azherebtsov force-pushed the oz-nvidia-memory-and-errors branch from b408e85 to 803694d Compare April 24, 2023 18:04
@azherebtsov
Copy link
Contributor Author

!signed-cla

Adding memory utilisation and page retirement metrics
@azherebtsov azherebtsov force-pushed the oz-nvidia-memory-and-errors branch from 803694d to 3b73fa5 Compare April 24, 2023 18:06
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but have one question inline I'd like answered before we merge.

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 24, 2023
@powersj powersj changed the title Nvidia-smi Memory metrics feat(inputs.nvidia_smi): add additional memory related fields Apr 24, 2023
@telegraf-tiger
Copy link
Contributor

@srebhan
Copy link
Member

srebhan commented Apr 25, 2023

@powersj are you fine with the answers of @azherebtsov?

@powersj
Copy link
Contributor

powersj commented Apr 25, 2023

@powersj are you fine with the answers of @azherebtsov?

yes!

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much for your contribution @azherebtsov!

@srebhan srebhan added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 26, 2023
@srebhan srebhan merged commit cd53516 into influxdata:master Apr 26, 2023
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants