Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(outputs.warp10): Support Infinity/-Infinity/NaN values #13126

Merged
merged 4 commits into from
Apr 24, 2023
Merged

fix(outputs.warp10): Support Infinity/-Infinity/NaN values #13126

merged 4 commits into from
Apr 24, 2023

Conversation

KannarFr
Copy link
Contributor

@KannarFr KannarFr commented Apr 21, 2023 •
edited
Loading

  • Wrote appropriate unit tests.

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@KannarFr
Copy link
Contributor Author

!signed-cla

@srebhan srebhan changed the title fix[warp10]: support Infinity/-Infinity/NaN values fix(outputs.warp10): Support Infinity/-Infinity/NaN values Apr 24, 2023
srebhan
srebhan reviewed Apr 24, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice fix @KannarFr! There is one issue in the code (see my comment below)...

@srebhan srebhan self-assigned this Apr 24, 2023
@srebhan srebhan added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Apr 24, 2023
@KannarFr KannarFr force-pushed the fixInfAndNaNForWarp10Output branch from 9970ec8 to 1800cca Compare April 24, 2023 16:45
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thanks @KannarFr!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 24, 2023
@srebhan srebhan assigned powersj and unassigned srebhan Apr 24, 2023
powersj
powersj approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR + tests!

@powersj powersj merged commit 1d3afd4 into influxdata:master Apr 24, 2023
powersj pushed a commit that referenced this pull request May 22, 2023
@KannarFr @powersj
fix(outputs.warp10): Support Infinity/-Infinity/NaN values (#13126)
a03ea24 
(cherry picked from commit 1d3afd4)
@p-linnane p-linnane mentioned this pull request May 22, 2023
Merged
@srebhan srebhan added this to the v1.26.3 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.26.3
Development

Successfully merging this pull request may close these issues.
3 participants
@KannarFr @powersj @srebhan