Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump github.com/netsampler/goflow2 from 1.1.1 to 1.3.3 #13104

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 17, 2023

Bumps github.com/netsampler/goflow2 from 1.1.1 to 1.3.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/netsampler/goflow2](https://github.com/netsampler/goflow2) from 1.1.1 to 1.3.1.
- [Release notes](https://github.com/netsampler/goflow2/releases)
- [Commits](netsampler/goflow2@v1.1.1...v1.3.1)

---
updated-dependencies:
- dependency-name: github.com/netsampler/goflow2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 17, 2023
@telegraf-tiger telegraf-tiger bot added the chore label Apr 17, 2023
@powersj
Copy link
Contributor

powersj commented Apr 20, 2023

plugins/inputs/netflow/netflow_decoder.go:530:36: undefined: netflow.BasicTemplateSystem

Looks like netsampler/goflow2#49 removed the templates into a different module :\

There was also an issue with UDP fixed in netsampler/goflow2#152 and v1.3.2 published. We should refactor to the new version and pull in the later version.

@lspgn
Copy link

lspgn commented Apr 21, 2023

@powersj my apologies :( I should have versioned it better

I made some changes to avoid having this issue. You can continue using the in-memory template system.

@powersj
Copy link
Contributor

powersj commented Apr 21, 2023

@powersj my apologies :( I should have versioned it better
I made some changes to avoid having this issue. You can continue using the in-memory template system.

thanks for the response! We will give 1.3.3 a spin then.

@powersj powersj changed the title chore(deps): Bump github.com/netsampler/goflow2 from 1.1.1 to 1.3.1 chore(deps): Bump github.com/netsampler/goflow2 from 1.1.1 to 1.3.3 Apr 24, 2023
@telegraf-tiger
Copy link
Contributor

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 24, 2023
@srebhan srebhan merged commit a1b777a into master Apr 25, 2023
@srebhan srebhan deleted the dependabot/go_modules/github.com/netsampler/goflow2-1.3.1 branch April 25, 2023 09:32
powersj pushed a commit that referenced this pull request May 22, 2023
@srebhan srebhan added this to the v1.26.3 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants