fix(inputs.socket_listener): Fix loss of connection tracking #13056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
041c9f1 to
8a1a567
Compare
Previously if an error was encountered during socket initialization, it would return early from the setupConnection function, and skip adding the connection to the tracking list. This could cause issues later down the line. This refactors the code so that setupConnection() only returns an error if the connection should be aborted. Otherwise messages should be written to the logger. fixes influxdata#13051
powersj
reviewed
Apr 10, 2023
3 tasks
|
closing as I don't have time to carry this. If someone else wants to pick it up, feel free |
srebhan
approved these changes
May 16, 2023
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
approved these changes
May 16, 2023
powersj
approved these changes
May 17, 2023
powersj
pushed a commit
that referenced
this pull request
May 22, 2023
(cherry picked from commit f098e5f)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if an error was encountered during socket initialization, it would return early from the setupConnection function, and skip adding the connection to the tracking list. This could cause issues later down the line.
This refactors the code so that setupConnection() only returns an error if the connection should be aborted. Otherwise messages should be written to the logger.
fixes #13051
Required for all PRs
resolves #