-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(secrets): Minimize secret holding time #13002
Merged
powersj
merged 6 commits into
influxdata:master
from
srebhan:secret_store_issue_sqlserver
Apr 3, 2023
Merged
fix(secrets): Minimize secret holding time #13002
powersj
merged 6 commits into
influxdata:master
from
srebhan:secret_store_issue_sqlserver
Apr 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d880cb6
to
947190c
Compare
powersj
approved these changes
Apr 3, 2023
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
added a commit
that referenced
this pull request
Apr 3, 2023
(cherry picked from commit 83b4056)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fix
pr to fix corresponding bug
plugin/secretstores
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #12924
based on #12919
In some places we hold the secrets longer than necessary or, in
inputs.sqlserver
, we spawn too many accesses to secrets. We recently discovered that this might lead to exceeding the limit of locked memory.This PR fixes all known locations and optimizes the access in
inputs.sqlserver
.