Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): Minimize secret holding time #13002

Merged
merged 6 commits into from
Apr 3, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Mar 31, 2023

relates to #12924
based on #12919

In some places we hold the secrets longer than necessary or, in inputs.sqlserver, we spawn too many accesses to secrets. We recently discovered that this might lead to exceeding the limit of locked memory.
This PR fixes all known locations and optimizes the access in inputs.sqlserver.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Mar 31, 2023
@srebhan srebhan force-pushed the secret_store_issue_sqlserver branch from d880cb6 to 947190c Compare April 3, 2023 11:43
@srebhan
Copy link
Member Author

srebhan commented Apr 3, 2023

Based on #13012 and #12919 and should be merged after those...

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 3, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Apr 3, 2023

@powersj powersj merged commit 83b4056 into influxdata:master Apr 3, 2023
srebhan added a commit that referenced this pull request Apr 3, 2023
@srebhan srebhan added this to the v1.26.1 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants