Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.graphite): add custom regex to outputs #12908

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Mar 20, 2023

Missed adding this correctly to the graphite output, only the parser in a previous PR.

fixes: #12832

Missed adding this correctly to the graphite output, only the parser in
a previous PR.

fixes: influxdata#12832
@telegraf-tiger telegraf-tiger bot added area/graphite fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Mar 20, 2023
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 21, 2023
@powersj powersj marked this pull request as ready for review March 21, 2023 13:28
srebhan
srebhan previously approved these changes Mar 21, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@srebhan srebhan dismissed their stale review March 21, 2023 15:41

One more comment...

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the new option also appear in the README?

@Hipska
Copy link
Contributor

Hipska commented Mar 21, 2023

It already is:

## Strict sanitization regex
## This is the default sanitization regex that is used on data passed to the
## graphite serializer. Users can add additional characters here if required.
## Be aware that the characters, '/' '@' '*' are always replaced with '_',
## '..' is replaced with '.', and '\' is removed even if added to the
## following regex.
# graphite_strict_sanitize_regex = '[^a-zA-Z0-9-:._=\p{L}]'

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for checking @Hipska! LGTM then.

@srebhan srebhan merged commit 3c8277d into influxdata:master Mar 22, 2023
srebhan pushed a commit that referenced this pull request Apr 3, 2023
@srebhan srebhan added this to the v1.26.1 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphite fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow customization of allowed chars in graphite output
3 participants