Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.ethtool): check for nil #12867

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Mar 14, 2023

fixes: #12866

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 14, 2023
@influxdata influxdata deleted a comment from telegraf-tiger bot Mar 14, 2023
@powersj powersj marked this pull request as ready for review March 17, 2023 13:09
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 17, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @powersj, just one comment regarding error checking...

@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @powersj!

@srebhan srebhan merged commit 02eea01 into influxdata:master Mar 22, 2023
@schlitzered
Copy link

we are affected by this as well, i can verify that the 1.27 build from this pull request solved the issue, when can we expect 1.27 to get released and hit the repositories?

@powersj
Copy link
Contributor Author

powersj commented Apr 3, 2023

This is a fix, so it will show up in 1.26.1 going out today or tomorrow

https://github.com/influxdata/telegraf/blob/master/docs/FAQ.md#when-will-my-pr-or-fix-get-released

srebhan pushed a commit that referenced this pull request Apr 3, 2023
@srebhan srebhan added this to the v1.26.1 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ethtool plugin panics consistently when probing an ena NIC (regression in v1.26.0)
3 participants