-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.win_eventlog): Add state-persistence capabilities #12790
Merged
powersj
merged 9 commits into
influxdata:master
from
srebhan:win_eventlog_state_persistence
Mar 7, 2023
Merged
feat(inputs.win_eventlog): Add state-persistence capabilities #12790
powersj
merged 9 commits into
influxdata:master
from
srebhan:win_eventlog_state_persistence
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/windows
Related to windows plugins (win_eventlog, win_perf_counters, win_services)
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finalizes #8352
follow up on PR #12166
This PR adds the possibility to remember the last-read log entry across Telegraf restart to make sure all log-entries are covered. To do so, we add state-persistence capabilities and introduce the API's exiting bookmarking functionality to this plugin.
Furthermore, we add a
from_beginning
flag which allows to read entries from the beginning of time if no state/bookmark exists.