Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disk label tag to disk plugin #12594 #12620

Closed
wants to merge 2 commits into from

Conversation

izenn
Copy link

@izenn izenn commented Feb 3, 2023

this adds the functionality of being able to associate partition information with a meaningful identifier (not dm-#)

resolves #12594

created an extended struct for disk partition information that added a new field for partition label, then used the disk.Label function from github.com/shirou/gopsutil/v3/disk to populate the field if the device starts with /dev

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 3, 2023
@izenn izenn mentioned this pull request Feb 3, 2023
@powersj
Copy link
Contributor

powersj commented Feb 6, 2023

Thanks for putting the PR up!

Error: plugins/inputs/conntrack/conntrack_test.go:126:7: cannot use &mps (value of type *"github.com/influxdata/telegraf/plugins/inputs/system".MockPS) as "github.com/influxdata/telegraf/plugins/inputs/system".PS value in struct literal: *"github.com/influxdata/telegraf/plugins/inputs/system".MockPS does not implement "github.com/influxdata/telegraf/plugins/inputs/system".PS (wrong type for method DiskUsage)

This is why I wanted a PR :) Since there is some mocking of the PS type used in other places, your updates may impact other plugins.

@powersj powersj self-assigned this Feb 15, 2023
@powersj
Copy link
Contributor

powersj commented Feb 17, 2023

I'm going to close this one in favor of #12696

@powersj powersj closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants