-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.exec): Restore pre-v1.21 behavior for CSV data_format #12533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
approved these changes
Jan 26, 2023
srebhan
added a commit
that referenced
this pull request
Jan 30, 2023
) (cherry picked from commit eb03bb5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/csv
csv parser/serialiser related
area/exec
fix
pr to fix corresponding bug
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
plugin/parser
1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #12022
This PR restores the CSV parsing behavior for
inputs.exec
to the one experienced in pre-v1.21 versions. In v1.21 the behavior suddenly changed to not resetting the parser anymore. While this is acceptable and expected for other plugins (see additional unit-tests), it is less helpful forexec
as the commands run usually output a complete CSV instead of incremental data-lines.