-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.sqlserver): Suppress error on secondary replicas #12528
fix(inputs.sqlserver): Suppress error on secondary replicas #12528
Conversation
@deweter can you please check why |
I believe that |
@spaghettidba - I changed it. Initially, I skipped it as I didn't test it, but in general I do agree that the error could appear most probably there too.
@srebhan - Sorry, my mistake - I removed a change to |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
@spaghettidba and @Trovalo any comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise this looks good to me. Waiting for @Trovalo's ok on this...
(cherry picked from commit 7e87a25)
Resolves #9530
This PR suppresses an error which we may encounter, if we query sys.dm_exec_requests DMV against a SQL Server hosting secondary replicas.