-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secretstores): Convert (most) output plugins #12497
feat(secretstores): Convert (most) output plugins #12497
Conversation
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
resolves #12484
This PR converts most output plugins to be able to use secrets and thus secret-store(s) for their credentials such as username and password and/or tokens. This leaves us with
outputs.health
andoutputs.prometheus_client
as those are listening for connections and are thus receiving credentials compared to all others which send credentials. The two mentioned plugins will be converted later.