-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intel_powerstat): Add CPU base frequency metric and add support for new platforms #12452
Conversation
…for new platforms
…for new platforms Co-authored-by: PanKaker <92713340+PanKaker@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this - just two questions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, my only comment is to make the missing of the cpu_base_frequency
feature a warn instead of a debug message. What do you think?
…for new platforms
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @p-zak!
Is it possible to add me to Co-authored list of the PR/commit to master? I was a person who implemented this feature, but because of lack CCLA permissions, we've decided to make this PR under p-zak's name. It will be great to see my account under the contribution section. |
Hey @PanKaker! Sorry for me missing out on mentioning you in the commit. However as we already merged this, adding you would require to edit git history with forced-push which will in turn give all current PR contributors a big headache. Please accept my apologies! |
Required for all PRs
Introduced multiple changes:
cpu_base_frequency_mhz
metric added (if configured by addingcpu_base_frequency
topackage_metrics
configuration option).New metric:
cpu_base_frequency_mhz
- will expose base frequency of CPU's package (in MHz)Example of output for new metric: