Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.cloudwatch): Add support for cross account oberservability #12448

Merged
merged 12 commits into from
May 24, 2023
Merged

feat(inputs.cloudwatch): Add support for cross account oberservability #12448

merged 12 commits into from
May 24, 2023

Conversation

ahsanali
Copy link
Contributor

resolves #12447

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 30, 2022
powersj
powersj reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! just one change to remove some commented out code. Also please let us know when you sign the CLA.

@ahsanali @powersj
feat: removing commented code
bcb9c03 
Co-authored-by: Joshua Powers <powersj@fastmail.com>
@ahsanali
Copy link
Contributor Author

ahsanali commented Jan 6, 2023

!signed-cla

@ahsanali
Copy link
Contributor Author

ahsanali commented Jan 6, 2023

thanks for the review @powersj

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 6, 2023
srebhan
srebhan reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice feature @ahsanali! I found an inconsistency in your sample config and have two small requests for code changes. Nothing too big. Can you please take a look?

ahsanali and others added 3 commits January 12, 2023 19:46
@ahsanali @srebhan
feat: adding support for cloudwatch cross account observability. fixi…
3035624 
…ng inconsistency in README

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@ahsanali @srebhan
@ahsanali @srebhan feat: adding support for cloudwatch cross account …
7c9596b 
…observability. reindenting code

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@ahsanali @srebhan
feat: adding support for cloudwatch cross account observability. rein…
d1bf9ab 
…denting code

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@srebhan
Copy link
Member

srebhan commented Jan 17, 2023

@ahsanali can you please run make docs to make the linter happy!?

@srebhan srebhan added the waiting for response waiting for response from contributor label Jan 25, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Feb 8, 2023

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you!

@telegraf-tiger telegraf-tiger bot closed this Feb 8, 2023
@powersj
Copy link
Contributor

powersj commented Feb 8, 2023

@ahsanali would be happy to see this updated so we can land it. Just let us know in a comment here

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Feb 8, 2023
@ahsanali
Copy link
Contributor Author

@powersj sorry for the delay. I have updated the fork. Should I create a new PR ?

@powersj powersj reopened this May 23, 2023
@powersj
Copy link
Contributor

powersj commented May 23, 2023

@ahsanali I have re-opened the PR. Could you push your additional changes and ping @srebhan when you are ready for another review?

Thanks!

@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@khurramcheema
Copy link

@srebhan please review and merge it, Thanks

srebhan
srebhan approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the nice feature @ahsanali!

@srebhan srebhan changed the title feat: Add support for cloudwatch cross account oberservability #12447 feat(inputs.cloudwatch): Add support for cross account oberservability May 24, 2023
@srebhan srebhan added cloud Issues or requests around cloud environments plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 24, 2023
@srebhan srebhan merged commit 2010926 into influxdata:master May 24, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 13, 2023
Merged
@srebhan srebhan added this to the v1.27.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
cloud Issues or requests around cloud environments feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.27.0
Development

Successfully merging this pull request may close these issues.

Add support for cloudwatch cross account oberservability
4 participants
@ahsanali @srebhan @powersj @khurramcheema