-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.sqlserver): SqlRequests include sleeping sessions with open transactions #12386
fix(inputs.sqlserver): SqlRequests include sleeping sessions with open transactions #12386
Conversation
Includes sleeping sessions with open transaction
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
makes sense to me, but I'd like to have also the opinion of @dimitri-furman as this will be implemented also for the Azure part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a useful change for all flavors of SQL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @spaghettidba!
example: Fixed an off by one error in counter variable in type FooBar.
SqlRequests did not include sleeping sessions with open transactions. This can make troubleshooting slightly problematic in some cases, where you see a blocked SPID but you don't see how long the blocking session has been sleeping. This fix will allow tracking sleeping sessions that keep transactions open.