Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.directory_monitor): Close input file before removal #12294

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Nov 28, 2022

resolves #12287

Contrary to other OS, on Windows we cannot remove a file when it is still open as in this case Windows thinks that someone still uses this file. So let's close the file before removing it to make all OSes happy.

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 28, 2022
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan merged commit c31f811 into influxdata:master Nov 29, 2022
@srebhan srebhan deleted the directory_monitor_issue_12287 branch November 29, 2022 13:06
powersj pushed a commit that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directory Monitor Input Plugin on Windows doesn't move file to "done" folder after writing data to influx.
2 participants