fix(inputs.prometheus): respect selectors when scraping pods #12278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs
field and labels selectors were ignored unless
pod_scrape_scope = "node"
was specified, this breaksmonitor_kubernetes_pods_method != "annotations"
(default), because then all pods become candidate for scraping.This PR enables field and label selectors. I am keeping existing behaviour where field and label selectors are not used with default pod scraping (
monitor_kubernetes_pods_method == "annotations"
) for now, but I'd prefer any pod scraping to respect selectors same as it currently respects namespace.