fix(inputs.gnmi): Fix empty name for Sonic device #12258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #12257
When used with a Sonic switch (4.0.2), the GNMI plugin produces an empty measurement name and in turn bails-out with
Could not serialize metric: invalid name
on the output side. The root cause of this is that the mentioned device reports the origin of the data as part of the first element in the formopenconfig-platform:components
for the update. This leads to a lookup error in the internal aliases map as usually the path is considered to be absolute and not including the origin.This PR first adds two test-cases reflecting the debug data gathered from the (non-working) Sonic device as well as a working Arista device. It then adds an error in case the name cannot be determined to better track-down the root cause of future error cases. The PR then checks for the unusual reporting behavior and, if applicable, correctly splits the first element into the origin and path element thus fixing the issue.