-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.cisco_telemetry_mdt): add operation-metric and class-policy #12240
fix(inputs.cisco_telemetry_mdt): add operation-metric and class-policy #12240
Conversation
… prefixes fix metrics getting overwrited when there are multiple class policies and operation metrics
Thanks so much for the pull request! |
@dd-accedian can you please sign the CLA and let me know once you are done?!? |
!signed-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dd-accedian thanks for the contribution. I've just one small comment...
fix(inputs.cisco_telemetry_mdt): switch instead of if statement for operation-metric and class-policy Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -1.53 % for linux amd64 (new size: 157.1 MB, nightly size 159.6 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the fix @dd-accedian!
… prefixes
fix metrics getting overwritten when there are multiple class policies and operation metrics
Required for all PRs
resolves #8261