Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.socket_ listener): Allow to specify message separator for streams #12187

Merged
merged 14 commits into from
Nov 17, 2022

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Nov 7, 2022

resolves #6025
potentially resolves #6920
partially resolves ##11952

This PR adds the ability to specify how messages should be split for stream sockets (e.g. TCP) using the new splitting_strategy option. Currently the PR implements splitting by newline (current behavior, default), by null byte, by a user specified byte-sequence (delimiter), by fixed message length or by dynamic message length found in some message header "field".

@srebhan srebhan changed the title feat(inputs.socket_ listener separator feat(inputs.socket_ listener): Allow to specify message separator for streams Nov 7, 2022
@srebhan srebhan force-pushed the socket_listener_separator branch from 5531538 to 631c0c8 Compare November 14, 2022 15:44
@srebhan srebhan closed this Nov 14, 2022
@srebhan srebhan reopened this Nov 14, 2022
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one change @srebhan then I'm +1

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 16, 2022
@powersj powersj self-assigned this Nov 16, 2022
@srebhan srebhan requested review from powersj and removed request for reimda November 16, 2022 22:41
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@powersj powersj merged commit 3160d52 into influxdata:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
3 participants