feat(ethtool): Possibility to skip gathering metrics for downed interfaces #12087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some interfaces can expose a few thousands fields. It may not be necessary to gather and expose metrics for interfaces which are not
UP
.This PR adds possibility to skip such metrics (but it defaults to exposing them - to be backward compatible):
Moreover, creation of
IncludeExcludeFilter
was moved fromGather
toInit
(input to this filter doesn't change so it makes sense to create it only once).