-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parsers.xpath): Allow to specify byte-array fields to encode in HEX #11999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7af5353
to
20dc85a
Compare
e2ecf6b
to
8648241
Compare
powersj
approved these changes
Nov 18, 2022
per tests: sounds like you need a |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/xml
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
plugin/parser
1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #11952
This PR adds the last missing part for supporting PowerDNS protocol-buffer messages. To do this, the PR adds an ability to specify byte-array fields (via
fields_bytes_as_hex
) that should be represented as HEX in thexpath
parser. This is necessary to be able to handle IP addresses and IDs correctly which would otherwise encoded as UTF-8 strings which are hard to reverse. The following configallows to send a message to the
socket_listener
input and retrieve a metric in the form