-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.modbus): Improve duplicate field checks #11912
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2022
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
MyaLongmire
approved these changes
Oct 3, 2022
powersj
approved these changes
Oct 4, 2022
dba-leshop
pushed a commit
to dba-leshop/telegraf
that referenced
this pull request
Oct 30, 2022
popey
pushed a commit
that referenced
this pull request
Nov 2, 2022
(cherry picked from commit 4b18183)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/modbus
fix
pr to fix corresponding bug
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #11865
related to #11911
This PR improves the check for duplicate fields in requests by also taking into account the tags of the request. This solves the case described in #11865.
Furthermore, it extends the unit-test by adding a framework for testing configurations. Several tests are added using this new possibility to check for the aforementioned issues.