Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.modbus): Improve duplicate field checks #11912

Merged
merged 7 commits into from
Oct 4, 2022

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Sep 30, 2022

resolves #11865
related to #11911

This PR improves the check for duplicate fields in requests by also taking into account the tags of the request. This solves the case described in #11865.
Furthermore, it extends the unit-test by adding a framework for testing configurations. Several tests are added using this new possibility to check for the aforementioned issues.

@telegraf-tiger telegraf-tiger bot added area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 30, 2022
@srebhan srebhan marked this pull request as draft September 30, 2022 15:11
@srebhan srebhan changed the title feat(inputs.modbus): Add unit-test framework for testing configurations to be valid/invalid. feat(inputs.modbus): Add unit-test framework for testing configurations Sep 30, 2022
@srebhan srebhan changed the title feat(inputs.modbus): Add unit-test framework for testing configurations fix(inputs.modbus): Improve duplicate field checks Sep 30, 2022
@srebhan srebhan marked this pull request as ready for review September 30, 2022 15:33
@srebhan srebhan added fix pr to fix corresponding bug and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Sep 30, 2022
@MyaLongmire MyaLongmire added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 3, 2022
@srebhan srebhan merged commit 4b18183 into influxdata:master Oct 4, 2022
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
popey pushed a commit that referenced this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.modbus.request does not allow same field names into different measurements
3 participants