-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser.xpath): Handle floating-point times correctly #11875
Conversation
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome and I appreciate you going through it in pairs. It does set up changes for #11544 nicely.
…fka-regexp Let Influx timestamp parsing from influxdata#11875 do the work for us
This simplified my life in #11816 considerably. Two thumbs up. |
(cherry picked from commit 758f2cb)
resolves #11864
lays foundation for resolving #11544
This PR fixes issues when providing the timestamp as floating-points in exponential notation. Furthermore, it revamps the internal
ParseTimestamp()
function to also return precise timestamps forunix_ms
andunix_ns
, handle above mentioned floating-point values and strings with thousand separators.