fix(inputs.modbus): Do not fail if a single slave reports errors #11785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #11782
In the current implementation the modbus plugin will error out as soon as the first slave fails. This is a problem when querying multiple slaves over one interface (as in #11782) or when using ModbusTCP gateways as we loose one gather cycle for all devices after a failing one.
The current PR changes this behavior and only skips the failing slave (after busy-retry) but continues with other ones in the row.