Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serializers.prometheus): give option to reduce payload size by removing HELP from payload #11690

Merged

Conversation

conorevans
Copy link
Contributor

@conorevans conorevans commented Aug 16, 2022

resolves #11390 (as much as is possible within Telegraf itself)

implements @srebhan feedback from #11417

Give option to reduce payload size by removing the HELP metadata from the payload.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 16, 2022
@conorevans
Copy link
Contributor Author

FYI @srebhan 👋

@powersj powersj requested a review from srebhan August 16, 2022 21:19
@sspaink sspaink changed the title feat(serializers/prometheus): give option to reduce payload size by removing HELP from payload feat(serializers.prometheus): give option to reduce payload size by removing HELP from payload Aug 16, 2022
Copy link
Contributor

@MyaLongmire MyaLongmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks @conorevans for the nice PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prometheus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/serializer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus serializer: remove HELP metadata and make TYPE metadata optional to cut down on traffic costs
4 participants