Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add coralogix dialect to opentelemetry #11622

Merged
merged 5 commits into from
Aug 8, 2022
Merged

feat: add coralogix dialect to opentelemetry #11622

merged 5 commits into from
Aug 8, 2022

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Aug 4, 2022

Required for all PRs

resolves #

Added an Coralogix dialect to opentelemetry output plugin so that users can send metrics to Coralogix.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 4, 2022
@povilasv povilasv mentioned this pull request Aug 4, 2022
Closed
3 tasks
srebhan
srebhan reviewed Aug 4, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is really nice @povilasv! Thanks for your effort! I've a suggestion regarding the configuration scheme and like to ask you to give users some more guidance by adding some more help to the README. What do you think?

@srebhan srebhan self-assigned this Aug 4, 2022
@srebhan srebhan added plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins area/telemetry All about OpenTelemetry and other telemetry variants labels Aug 4, 2022
@povilasv @srebhan
Apply suggestions from code review
b1172d4 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@povilasv
Copy link
Contributor Author

povilasv commented Aug 4, 2022 •
edited
Loading

@srebhan thanks for taking a look ❤️ , updated the PR with your suggestions :)

@povilasv povilasv force-pushed the openetelemetry-coralogix branch 2 times, most recently from 172e809 to 672cb4f Compare August 4, 2022 12:10
@povilasv povilasv force-pushed the openetelemetry-coralogix branch from 672cb4f to 9127376 Compare August 4, 2022 12:14
@povilasv povilasv requested a review from srebhan August 4, 2022 12:52
srebhan
srebhan reviewed Aug 5, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good @povilasv. Please use = in the TOML config and make sure that the sample.conf setting-names are reflected in the code. I think I marked all critical locations in the code, but please check again!

povilasv and others added 2 commits August 8, 2022 09:26
@povilasv @srebhan
Apply suggestions from code review
a26aa2e 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@povilasv
fixes after review
7b8f2c1
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Aug 8, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@povilasv
Copy link
Contributor Author

povilasv commented Aug 8, 2022

@srebhan thanks for noting, somehow I missed it. I tested the new code locally and it works :)

srebhan
srebhan approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Looks good to me. Thanks for your effort and willingness to help us keeping maintainability @povilasv!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 8, 2022
powersj
powersj approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@powersj powersj merged commit ce2053d into influxdata:master Aug 8, 2022
reimda pushed a commit that referenced this pull request Aug 15, 2022
@povilasv @reimda
feat: add coralogix dialect to opentelemetry (#11622)
99043a7 
(cherry picked from commit ce2053d)
reimda pushed a commit that referenced this pull request Aug 16, 2022
@povilasv @reimda
feat: add coralogix dialect to opentelemetry (#11622)
68928c5 
(cherry picked from commit ce2053d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/telemetry All about OpenTelemetry and other telemetry variants feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@povilasv @powersj @srebhan