-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(outputs): Linter issues #11595
Merged
Merged
fix(outputs): Linter issues #11595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
reviewed
Aug 2, 2022
powersj
approved these changes
Aug 2, 2022
sspaink
approved these changes
Aug 3, 2022
reimda
pushed a commit
that referenced
this pull request
Aug 15, 2022
(cherry picked from commit ac26d78)
reimda
pushed a commit
that referenced
this pull request
Aug 16, 2022
(cherry picked from commit ac26d78)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fix
pr to fix corresponding bug
linter
plugin/output
1. Request for new output plugins 2. Issues/PRs that are related to out plugins
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes linter issues in
plugins/outputs
. After applying this only two issues inplugins/outputs/socket_writer
andplugins/outputs/syslog
regarding deprecation oferr.Temportary()
remain. However, fixing those is not straight forward and should be tackled in another PR.