Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.sqlserver): set lower deadlock priority #11522

Merged

Conversation

buffalovagabond
Copy link
Contributor

resolves #10908

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jul 19, 2022
@MyaLongmire
Copy link
Contributor

@buffalovagabond Thank you for this pr!

It seems the test-go-linux test is failing. Can you please run make docs and then push the updated README?

@MyaLongmire MyaLongmire self-assigned this Jul 19, 2022
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thanks for this PR! This looks pretty straightforward and aligns with the previous changes. Can you rebase your repo on master? I just merged in a fix for the docs, so with that fix, your tests should fully run.

Thanks!

@buffalovagabond buffalovagabond force-pushed the sqlserver-deadlock-priority branch from 5bd8b8a to 93ec041 Compare July 19, 2022 15:42
@buffalovagabond
Copy link
Contributor Author

@powersj I just rebased my branch on master.
Thanks for fixing the docs.

@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@MyaLongmire MyaLongmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

@powersj powersj merged commit ae695e8 into influxdata:master Jul 19, 2022
MyaLongmire pushed a commit that referenced this pull request Jul 25, 2022
@a-venger
Copy link
Contributor

@MyaLongmire @powersj
Hi
Sorry for bothering you.

Any reason why this was done for V2 queries but not for the newer one database_type = "SQLServer"?

@powersj
Copy link
Contributor

powersj commented Jul 26, 2022

Any reason why this was done for V2 queries but not for the newer one database_type = "SQLServer"?

Happy to see a PR for the queries in sqlserverqueries.go as well.

@a-venger
Copy link
Contributor

Any reason why this was done for V2 queries but not for the newer one database_type = "SQLServer"?

Happy to see a PR for the queries in sqlserverqueries.go as well.

#11549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

telegraf for windows - [inputs.sqlserver] Set deadlock priority to LOW
4 participants