-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.sqlserver): set lower deadlock priority #11522
fix(inputs.sqlserver): set lower deadlock priority #11522
Conversation
@buffalovagabond Thank you for this pr! It seems the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Thanks for this PR! This looks pretty straightforward and aligns with the previous changes. Can you rebase your repo on master? I just merged in a fix for the docs, so with that fix, your tests should fully run.
Thanks!
5bd8b8a
to
93ec041
Compare
@powersj I just rebased my branch on master. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix!
(cherry picked from commit ae695e8)
@MyaLongmire @powersj Any reason why this was done for V2 queries but not for the newer one database_type = "SQLServer"? |
Happy to see a PR for the queries in sqlserverqueries.go as well. |
|
resolves #10908