Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate influx and influx_upstream parsers to new style #11432

Merged
merged 6 commits into from
Jul 6, 2022

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Jun 30, 2022

resolves #11358

This PR migrates the influx parser and influx_upstream parser to the new-style parser structure. The change is backward compatible. Furthermore, we cleanup the parser a bit.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 30, 2022
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @sspaink! I do have a few comments, but nothing too big.

@srebhan srebhan self-assigned this Jul 5, 2022
@srebhan srebhan added the plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins label Jul 5, 2022
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more small comment... :-)

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you @sspaink for migrating the influx parsers!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 6, 2022
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jul 6, 2022

@sspaink sspaink merged commit 9744c3a into master Jul 6, 2022
@sspaink sspaink deleted the migrateinflux branch July 6, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate influx and influx_upstream to new parser structure
2 participants