Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add autorestart and restartdelay flags to Windows service #10559

Merged
merged 3 commits into from
Feb 3, 2022

Conversation

R290
Copy link
Contributor

@R290 R290 commented Feb 1, 2022

Required for all PRs:

resolves #10522

The Windows service library used contains a list of known key value options: https://github.com/kardianos/service/blob/5c08916379a92cb1806764e911af33c55762a753/service.go#L190. I added the --service-auto-restart and --service-restart-delay flags to make the following options available:

//    - OnFailure               string ("restart" )   - Action to perform on service failure. (restart | reboot | noaction)
//    - OnFailureDelayDuration  string ( "1s" )       - Delay before restarting the service, time.Duration string.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 1, 2022
@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 1, 2022
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@powersj powersj merged commit 48682ff into influxdata:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add autorestart and optional restartdelay flags for creating Windows service
3 participants