feat(inputs.win_perf_counter): allow errors to be ignored #10535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 72204df.
3 tasks
reimda
reviewed
Jan 27, 2022
Comment on lines
+38
to
+43
| ## Accepts a list of PDH error codes which are defined in pdh.go, if this error is encountered it will be ignored | ||
| ## For example, you can provide "PDH_NO_DATA" to ignore performance counters with no instances | ||
| ## By default no errors are ignored | ||
| ## You can find the list here: https://github.com/influxdata/telegraf/blob/master/plugins/inputs/win_perf_counters/pdh.go | ||
| ## e.g.: IgnoredErrors = ["PDH_NO_DATA"] | ||
| # IgnoredErrors = [] |
There was a problem hiding this comment.
I think this needs to be copied into the readme.md too
There was a problem hiding this comment.
|
📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
powersj
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve: #7281
I took the PR started by (#7282) @bielawb (thanks!) to resolve the outstanding issues. To avoid using a boolean in the config as the original PR suggested, I replaced it with a list of strings accepting the names of any PDH (Performance Data Helper) error instead of only allowing to ignore
PDH_NO_DATA. I also added a unit test which was a blocker for the original PR.Yet again thanks @bielawb for the original PR, if you have sometime to test these new changes and give any feedback that would be appreciated. Your PR was open for a while so sorry about that!