Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add more functionality to template processor #10316

Merged
merged 4 commits into from
Dec 23, 2021
Merged

feat: Add more functionality to template processor #10316

merged 4 commits into from
Dec 23, 2021

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Dec 21, 2021 •
edited
Loading

Required for all PRs:

I was surprised the template processor didn't support {{.}} in a usable way.

- {0xc0000565a0}
+ test1 map[tag1:value1] map[value:1] 1257894000000000000

In the meantime, I also added support for {{ .FieldList }} and {{ .TagList }}.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 21, 2021
@Hipska Hipska requested a review from srebhan December 21, 2021 08:55
srebhan
srebhan approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @Hipska! Looks good to me.

@srebhan srebhan self-assigned this Dec 21, 2021
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 21, 2021
@Hipska
Copy link
Contributor Author

Hipska commented Dec 23, 2021

@powersj something like this?

powersj
powersj approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@telegraf-tiger
Copy link
Contributor

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb s390x.rpm linux_amd64.tar.gz
mipsel.deb x86_64.rpm linux_arm64.tar.gz
ppc64el.deb linux_armel.tar.gz
s390x.deb linux_armhf.tar.gz
linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj powersj merged commit 0b99c6c into influxdata:master Dec 23, 2021
@Hipska Hipska deleted the feature/template branch January 10, 2022 09:16
powersj pushed a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
@Hipska @powersj
feat: add more functionality to template processor (influxdata#10316)
c7b00b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hipska @powersj @srebhan