-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: panic due to no module #10303
fix: panic due to no module #10303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remark as maintainer of gosmi, You know the module name, but aren't doing anything with it, so you traverse all the loaded mibs in order to find one node that might happen to have the same name.
Added module but remove the server mib test as I hand wrote the mib and believe it is invalid. There is a reason people do not handwrite mibs as they are very complex. The tests were based on invalid mibs to begin with, I kept all of the ieft valid mibs to keep the validity of the tests. |
📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
(cherry picked from commit 1e81d98)
This reverts commit 1e81d98.
Required for all PRs:
resolves #10290
THIS IS A DRAFT! Loaded module in to prevent panic on IETF mibs. Has been tested by community members to fix their panics. Now loads in a module and passes the
gosmi.SmiNode
to other function so the node does not get lost and cause a panic.