-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(outputs/azure_data_explorer): Added azureBlob controls to lower RAM usage #10179
Conversation
@AsafMah can you please mark the PR as draft for the time being to prevent me to read this PR description over and over because I forgot it's not yet for review... :-D |
# Conflicts: # go.mod
# Conflicts: # go.mod
@srebhan The pr is ready now The tests seem to fail on unrelated parts - telegraf/plugins/outputs/azure_monitor |
You have updated a large number of azure libraries and I believe that is causing the tests to fail. Our nightly tests are not failing. You will need to ensure these tests continue to pass. |
@AsafMah as @powersj stated, the tests before your PR are all green and after your PR those are not green anymore. So it might be that library updates cause the issue, but anyhow, you need to identify the source of this problem as failing tests indicate some change in behavior of the plugin. Please take a look and check what fails and why! |
Ok yes, it did seem to be a problem with an upgraded version of a dependency messing with a test that tries to have mock MSI login. @powersj @evanphx it seems that the windows build failed because of an infrastructure problem, and I don't have the permission to re-run it, so can you do that? thanks |
Looks like CircleCI is having issues right now. I've hit cancel, but it seems to be spinning there. I can try to check in again a bit later if someone does not get to it first. |
👍 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
It seems to pass now, can someone review? |
@srebhan - All green now, can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AsafMah thanks for your effort. The code looks good to me, just one small style suggestion. However, it's ok for me to be merged like this.
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@AsafMah can you please run |
Done. |
Required for all PRs:
(This PR is waiting until we release the next version of azure-kusto-go with this API)
(What are the guidelines if the issue wasn't raised on github? should I create it myself?)
resolves #
Added azureBlob controls to lower RAM usage