Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed snmptranslate from readme and fix default path #10136

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

MyaLongmire
Copy link
Contributor

@MyaLongmire MyaLongmire commented Nov 19, 2021

Required for all PRs:

snmp_trap was reworked to use gosmi for mib look up but the readme still stated snmptranslate. Removed the snmptranslate section from the readme.

Also fix default path to use the suggested path from the readme if none is specified.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Nov 19, 2021
@MyaLongmire MyaLongmire mentioned this pull request Nov 19, 2021
2 tasks
@MyaLongmire MyaLongmire added docs Issues related to Telegraf documentation and configuration descriptions ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed fix pr to fix corresponding bug labels Nov 19, 2021
@Hipska
Copy link
Contributor

Hipska commented Nov 19, 2021

Could you also fix the fact that the default path is not used as suggested by the commented code?

In reality, If you don’t specify a path, No mins are loaded…

@Hipska Hipska self-assigned this Nov 19, 2021
@MyaLongmire MyaLongmire changed the title fix: removed snmptranslate from readme as it uses gosmi now fix: removed snmptranslate from readme and fix default path Nov 22, 2021
@powersj powersj merged commit 2b43934 into master Nov 23, 2021
@powersj powersj deleted the snmp-trap-readme branch November 23, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snmp docs Issues related to Telegraf documentation and configuration descriptions ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants