-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update BurntSushi/toml for hex config support #10089
fix: update BurntSushi/toml for hex config support #10089
Conversation
Signed-off-by: David Buettner <david.buettner@siemens.com>
Signed-off-by: David Buettner <david.buettner@siemens.com>
👍 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them **here**! 🐯Artifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are about 100 commits/3 years between those versions. Lots of tests, lexing, and lint fixes. Issue about leading zero regression. Otherwise no other references to regressions.
+1
Just added test to parse a hex value into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
(cherry picked from commit b9c444b)
plugins/common/shim/config_test.go
resolves #10088
Bump up version of BurntSushi/toml to v0.4.1
Local tests:
make check
andmake test
run successfullymake test-integration
runs with two failures, which locally on my machine also fail with the current master (i.e. same behavior forBurntSushi/toml v0.3.1
andv0.4.1
:FAIL github.com/influxdata/telegraf/plugins/inputs/ping 10.169s
FAIL github.com/influxdata/telegraf/plugins/outputs/mongodb 65.052s